Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing DSN field into the SentryEnvelopeHeade #1050

Merged
merged 26 commits into from
Oct 7, 2022
Merged

Added missing DSN field into the SentryEnvelopeHeade #1050

merged 26 commits into from
Oct 7, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 7, 2022 •
edited
Loading

📜 Description

Cont. #873

💡 Motivation and Context

Part of #872

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto mentioned this pull request Oct 7, 2022
Closed
5 tasks
@marandaneto marandaneto marked this pull request as ready for review October 7, 2022 09:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022 •
edited
Loading

Codecov Report

Base: 90.44% // Head: 90.45% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a33faf9) compared to base (b8b9b7b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
+ Coverage   90.44%   90.45%   +0.01%     
==========================================
  Files         114      114              
  Lines        3578     3584       +6     
==========================================
+ Hits         3236     3242       +6     
  Misses        342      342
Impacted Files Coverage Δ
dart/lib/src/sentry_client.dart 93.52% <100.00%> (+0.14%) ⬆️
dart/lib/src/sentry_envelope.dart 100.00% <100.00%> (ø)
dart/lib/src/sentry_envelope_header.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

krystofwoldrich
krystofwoldrich approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@marandaneto marandaneto merged commit fe217ba into main Oct 7, 2022
@marandaneto marandaneto deleted the sentry_tunnel branch October 7, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind left review comments

@ueman ueman ueman left review comments

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@brustolin brustolin Awaiting requested review from brustolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marandaneto @codecov-commenter @ueman @vaind @krystofwoldrich @vishnukvmd @ua741